[PATCH] xfs: remove int casts from debug dquot soft limit timer asserts

Ben Myers bpm at sgi.com
Thu Jan 3 16:14:26 CST 2013


On Fri, Dec 21, 2012 at 10:45:17AM -0500, Brian Foster wrote:
> The int casts here make it easy to trigger an assert with a large
> soft limit. For example, set a >4TB soft limit on an empty volume
> to reproduce a (0 > -x) comparison due to an overflow of
> d_blk_softlimit.
> 
> Signed-off-by: Brian Foster <bfoster at redhat.com>

Looks good.

Reviewed-by: Ben Myers <bpm at sgi.com>

committed to git://oss.sgi.com/xfs/xfs.git master and for-next branches



More information about the xfs mailing list