[PATCH] xfstests: don't remove trailing zeros from integers

Eric Whitney enwlinux at gmail.com
Thu Feb 28 18:26:37 CST 2013


_within_tolerance strips trailing zeros from the min and max range
values it outputs.  This leads to damage if the min or max value is
an integer containing trailing zeros rather than a real number with
a fractional part containing trailing zeros. Xfstest 289 can exhibit
this problem when its input is out of range.  Modify the code so it
will only remove trailing zeros found after a decimal point.

Signed-off-by: Eric Whitney <enwlinux at gmail.com>
---
 common.filter |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/common.filter b/common.filter
index 9e4c90c..1df2f97 100644
--- a/common.filter
+++ b/common.filter
@@ -106,8 +106,10 @@ EOF
 
   # fix up min, max precision for output
   # can vary for 5.3, 6.2
-  _min=`echo $_min | sed -e 's/0*$//'` # get rid of trailling zeroes
-  _max=`echo $_max | sed -e 's/0*$//'` # get rid of trailling zeroes
+
+  # remove any trailing zeroes from min, max if they have fractional parts
+  _min=`echo $_min | sed -e '/\./s/0*$//'`
+  _max=`echo $_max | sed -e '/\./s/0*$//'`
 
   if [ $_in_range -eq 1 ] 
   then
-- 
1.7.10.4



More information about the xfs mailing list