[PATCH] xfstests: use native definition of O_DIRECT flag

Dave Chinner david at fromorbit.com
Tue Feb 26 16:57:18 CST 2013


On Tue, Feb 26, 2013 at 04:03:22PM -0500, Eric Whitney wrote:
> The definition of O_DIRECT in src/trunc.c causes xfstest 125 to fail
> when run on a Pandaboard.  On ARM, the value used (0x040000) is
> O_DIRECTORY rather than O_DIRECT as it is on x86.  Prefer the platform's
> native definition of O_DIRECT supplied by fcntl.h if available.  Also,
> fix a couple of error messages to properly reflect their context.
> 
> Signed-off-by: Eric Whitney <enwlinux at gmail.com>

Looks good.

Reviewed-by: Dave Chinner <dchinner at redhat.com>
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list