[PATCH v4 0/6] speculative preallocation quota throttling
Dave Chinner
david at fromorbit.com
Fri Feb 22 19:50:15 CST 2013
On Fri, Feb 22, 2013 at 02:09:04PM -0600, Mark Tinguely wrote:
>
> -- since I am being a grouch ... ---
> I wish I had caught in the review for commit a1e16c26 that
> xfs_iomap_eof_prealloc_initial_size() is returning an int rather
> than xfs_fsblock_t for consistency.
Which is a bug, not an inconsistency. It means that alloc_blocks may
not return the right thing at the 2^31/2^32 FSB boundary.
Don't grouch like you can't possibly fix it, just send a patch. :P
The code isn't upstream yet, so we've got the entire 3.9-rc cycle to
fix it... :)
Cheers,
Dave.
--
Dave Chinner
david at fromorbit.com
More information about the xfs
mailing list