xfsprogs: fix warning in libxcmd/input.c

Mark Tinguely tinguely at sgi.com
Fri Feb 1 15:43:55 CST 2013


On 02/01/13 15:36, Ben Myers wrote:
> Fix an error when building with -Werror=format-security.
>
> input.c: In function 'fetchline':
> input.c:91:2: error: format not a string literal and no format arguments [-Werror=format-security]
>
> Signed-off-by: Ben Myers<bpm at sgi.com>
> Reported by: Arkadiusz Miśkiewicz<arekm at maven.pl>
> Index: xfsprogs/libxcmd/input.c
> ===================================================================
> --- xfsprogs.orig/libxcmd/input.c	2013-02-01 15:29:47.069894522 -0600
> +++ xfsprogs/libxcmd/input.c	2013-02-01 15:30:00.845895188 -0600
> @@ -88,7 +88,7 @@
>
>   	if (!line)
>   		return NULL;
> -	printf(get_prompt());
> +	printf("%s", get_prompt());
>   	fflush(stdout);
>   	if (!fgets(line, MAXREADLINESZ, stdin)) {
>   		free(line);
>
> _______________________________________________
> xfs mailing list
> xfs at oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

Looks good.

Reviewed-by: Mark Tinguely <tinguely at sgi.com>



More information about the xfs mailing list