[PATCH 2/10] xfs: xfs_bulkstat_single consolidation

Jeff Liu jeff.liu at oracle.com
Tue Dec 31 03:51:33 CST 2013


On 2013年12月31日 02:35, Mark Tinguely wrote:
> On 12/28/13 05:20, Jeff Liu wrote:
>> From: Jie Liu<jeff.liu at oracle.com>
>>
>> In xfs_bulkstat_single(), xfs_bulkstat_one() and xfs_bulkstat() might
>> return different error if either call failed, we'd better return the
>> proper error in this case.  Moreover, the function argument done is
>> useless in terms of xfs_ioc_bulkstat(), hence we can get rid of it.
>>
>> Signed-off-by: Jie Liu<jeff.liu at oracle.com>
>> ---
> 
> Yes, I know dmapi is not loved here but SGI still uses it and it wants
> the done flag still..
My mistake.  At that time, I noticed that there has comments about this
in xfs_ioc_bulkstat(), i.e,

 /* done = 1 if there are more stats to get and if bulkstat */
 /* should be called again (unused here, but used in dmapi) */

However, I failed to find out why it would be called by going through
the dmapi source code...

I'll keep this argument in next round of post.

Thanks,
-Jeff



More information about the xfs mailing list