[PATCH v2 12/12] xfstests: check if filesystem supports chattr

[Junho Ryu]

Hi Christoph,

I'm not sure what you meant by "it might be worth to have a common
_require_chattr helper chared with generic/079". I cannot find
"chattr" in "generic/079".

Regards,
Junho

On Tue, Dec 17, 2013 at 2:18 PM, Junho Ryu <jayr at google.com> wrote:
> Add _require_chattr which verifies exit code of chattr command and call
> it before running generic/277.
>
> Signed-off-by: Junho Ryu <jayr at google.com>
> ---
>
> v2: extracted from patch 9
>
>  common/attr       | 13 +++++++++++++
>  tests/generic/277 |  2 ++
>  2 files changed, 15 insertions(+)
>
> diff --git a/common/attr b/common/attr
> index 4a3ac9e..278633f 100644
> --- a/common/attr
> +++ b/common/attr
> @@ -218,5 +218,18 @@ else # Assume max ~1 block of attrs
>  fi
>
>  export MAX_ATTRVAL_SIZE
> +
> +_require_chattr()
> +{
> +    touch $TEST_DIR/syscalltest
> +    chattr +A $TEST_DIR/syscalltest > $TEST_DIR/syscalltest.out 2>&1
> +    if [ $? -ne 0 ]; then
> +      _notrun "chattr has failed to change attribute of a file in TEST_DIR"
> +    fi
> +    cat $TEST_DIR/syscalltest.out >> $seqres.full
> +
> +    rm -f $TEST_DIR/syscalltest.out
> +}
> +
>  # make sure this script returns success
>  /bin/true
> diff --git a/tests/generic/277 b/tests/generic/277
> index 8461ad9..c31f7c4 100755
> --- a/tests/generic/277
> +++ b/tests/generic/277
> @@ -38,11 +38,13 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15
>  # get standard environment, filters and checks
>  . ./common/rc
>  . ./common/filter
> +. ./common/attr
>
>  # real QA test starts here
>  _supported_fs generic
>  _supported_os Linux
>  _require_scratch
> +_require_chattr
>
>  _scratch_mkfs > /dev/null 2>&1
>  _scratch_mount
> --
> 1.8.5.1
>