[PATCH 01/10] xfs: remove duplicate code in xlog_cil_insert_format_items

Christoph Hellwig hch at infradead.org
Tue Dec 10 10:18:27 CST 2013


On Mon, Dec 09, 2013 at 01:45:48PM -0600, Ben Myers wrote:
> > +			if (ordered) {
> > +				/* track as an ordered logvec */
> > +				ASSERT(lip->li_lv == NULL);
> > +				lv->lv_buf_len = XFS_LOG_VEC_ORDERED;
> > +				goto insert;
> 
> It looks like lv->lv_niovecs is no longer being set in this case.  Was that intentional?

Yes, ordered log vecs don't have iovecs attached, so the implicit zero
from the kmem_zalloc is the right value.



More information about the xfs mailing list