[ANNOUNCE] xfstests: tree updated to 0a7f216b

Rich Johnston rjohnston at sgi.com
Tue Dec 3 07:36:08 CST 2013



On 12/02/2013 11:08 PM, Dave Chinner wrote:
> Hi folks,
>
> I've just committed some outstanding patches to the xfstests
> repository. The commits are listed below for your information,
> with the current head being:
>
> 0a7f216b7962fd15e0fd749110776ca69b718932 generic: add a rename fsync test
>
> Some book-keeping stuff follows.
>
> Firstly, I'm going to look into adding commit hooks into the
> xfstests repository to get it send automated commit message emails
> when the repo is updated like is done for the main xfs kernel
> repository. That will save having to walk through every patch
> replying to say "applied".
>
> I'd like to start by getting those emails sent to the XFS, btrfs and
> ext4 mailing lists, but I'm open to having them sent elsewhere, too.
> I'm open to ideas about whether this is too many lists or
> whether there are other lists we should send such email to.
>
> Secondly, you might note that I rewrote the subject lines of the
> commits below. The main reason for doing this is to make the git log
> readable and to give an idea of what was changed in the commit. So,
> some new conventions I'd like to see people try to use for their
> xfstests patch descriptions.
>
> 	1. the first word describes the tests/ subdirectory the
> 	   change belongs to. e.g. xfs, btrfs, generic, shared, etc
>
> 	2. if it's an infrastructure change or touches multiple
> 	   different sets of tests, then use "xfstests" as the keyword
>
> 	3. Don't use test numbers in commit messages or subject
> 	   lines for new tests. We typically have to renumber tests
> 	   as part of the commit process, so if we forget to modify
> 	   the commit message then it looks rather strange....
>
> 	4. when fixing a specific test, always refer to it as
> 	   "<subdir>/<name>", such as generic/273 or btrfs/022.
> 	   This is needed because we can have duplicate test names
> 	   in different sub directories.
>
> Hence a typical set of subjects might be:
>
> xfs: fix fubaroo in xfs/299
> generic: use correct frobnozzle on generic/230
> xfstests: prevent bozo errors when compiling ltp/iogen.c
>
> This makes life easier when browsing the commit history. I'll be
> modifying subject lines as I process them to follow these
> conventions, so if people adopt them it makes it better for
> everyone.
>
> Lastly, I'm going to try to keep the commit latency of reviewed
> xfstests patches to around 24-48 hours after the patch has been
> reviewed. I don't want reviewed patches to sit around for weeks
> before they are committed, so please ping the patch if it's been
> reviewed and not committed after a couple of days.
>
> Thanks all,
>
> Dave.
>
> ----
>
> Anand Jain (1):
>        * [ed14876] btrfs: test if raids are actually created
>
> Brian Foster (1):
>        * [0746f7b] generic: use correct size value in generic/273
>
> Christoph Hellwig (1):
>        * [c041421] xfstests: stop special casing nfs and udf
>
> Jie Liu (1):
>        * [5bcbff9] xfs: verify xfs_quota commands against invalid mount path
>
> Josef Bacik (3):
>        * [cb5dd61] btrfs: add basic qgroup testing
>        * [640d1e1] generic: add new test for fsync() on directories
>        * [0a7f216] generic: add a rename fsync test
>
> Miao Xie (1):
>        * [bd50b75] btrfs: add wrong compression type regression test
>
Hey Dave,
I should have mentioned to the list as that I was going to be out last 
week (as Ben did). I was catching up on my  normal work and had planned 
on committing the above commits this morning. Thanks for doing this.

--Rich



More information about the xfs mailing list