[PATCH] fs: fix iversion handling
Dave Chinner
david at fromorbit.com
Mon Dec 2 17:25:06 CST 2013
On Tue, Nov 19, 2013 at 07:17:07AM -0800, Christoph Hellwig wrote:
> Currently notify_change directly updates i_version for size updates,
> which not only is counter to how all other fields are updated through
> struct iattr, but also breaks XFS, which need inode updates to happen
> under its own lock, and synchronized to the structure that gets written
> to the log.
>
> Remove the update in the common code, and it to btrfs and ext4,
> XFS already does a proper updaste internally and currently gets a
> double update with the existing code.
>
> IMHO this is 3.13 and -stable material and should go in through the XFS
> tree.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
Looks good to me.
Reviewed-by: Dave Chinner <dchinner at redhat.com>
--
Dave Chinner
david at fromorbit.com
More information about the xfs
mailing list