[PATCH 07/15] mkfs: structify input parameter passing

Dave Chinner david at fromorbit.com
Mon Dec 2 17:16:48 CST 2013


On Mon, Dec 02, 2013 at 09:11:03AM -0800, Christoph Hellwig wrote:
> > +	const char	name;
> > +	const char	*subopts[MAX_SUBOPTS];
> > +	struct subopt_param {
> > +		int		index;
> > +		long long	minval;
> > +		long long	maxval;
> > +	}		subopt_params[MAX_SUBOPTS];
> > +};
> 
> Any reason to have a separate array for subopts instead of
> moving it into struct subopt_param?

getsubopt() requires a array of tokens for it's parsing, hence the
separation of the subopts names and the related parameters.

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list