[PATCH 15/15] mkfs: don't treat files as though they are block devices

Christoph Hellwig hch at infradead.org
Mon Dec 2 11:24:41 CST 2013


>  void
>  platform_flush_device(int fd, dev_t device)
>  {
> -	if (major(device) != RAMDISK_MAJOR)
> +	struct stat64	st;
> +	if (major(device) == RAMDISK_MAJOR)
> +		return;
> +
> +	if (fstat64(fd, &st) < 0)
> +		return;
> +
> +	if (S_ISREG(st.st_mode))
> +		fsync(fd);
> +	else
>  		ioctl(fd, BLKFLSBUF, 0);
>  }

Given that fsync does the right thing for device on Linux aswell
I'd suggest we make this function call it all the time and get rid
of all the ramdisk magic.

Should probabbly be a a separate patch.



More information about the xfs mailing list