[PATCH 07/15] mkfs: structify input parameter passing

Christoph Hellwig hch at infradead.org
Mon Dec 2 11:11:03 CST 2013


> +	const char	name;
> +	const char	*subopts[MAX_SUBOPTS];
> +	struct subopt_param {
> +		int		index;
> +		long long	minval;
> +		long long	maxval;
> +	}		subopt_params[MAX_SUBOPTS];
> +};

Any reason to have a separate array for subopts instead of
moving it into struct subopt_param?

Except for that I really like the approach!

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list