[PATCH 05/15] mkfs: factor boolean option parsing

Christoph Hellwig hch at infradead.org
Mon Dec 2 04:46:31 CST 2013


On Fri, Nov 29, 2013 at 12:43:40PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> Many of the options passed to mkfs have boolean options (0 or 1) and
> all hand roll the same code and validity checks. Factor these out
> into a common function.
> 
> Note that the lazy-count option is now changed to match other
> booleans in that if you don't specify a value, it reverts to the
> default value (on) rather than throwing an error. Similarly the -m
> crc and -n ftype options default to off rather than throwing an
> error.

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>

Unrelated question that came up when reading through this patch:

should we start deprecating some options that have long been the
default, like lazy-count or attrv1?



More information about the xfs mailing list