[PATCH] mkfs: add noalign option to usage()
Eric Sandeen
sandeen at sandeen.net
Thu Aug 29 10:56:20 CDT 2013
On 8/29/13 10:26 AM, Carlos Maiolino wrote:
> Although it has been added to manpage, there is no information about the
> existence of noalign option into the usage().
>
> Signed-off-by: Carlos Maiolino <cmaiolino at redhat.com>
> ---
> mkfs/xfs_mkfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 4bdacee..65630d4 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3033,7 +3033,7 @@ usage( void )
> /* metadata */ [-m crc=[0|1]\n\
> /* data subvol */ [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
> (sunit=value,swidth=value|su=num,sw=num),\n\
> - sectlog=n|sectsize=num\n\
> + noalign, sectlog=n|sectsize=num\n\
SUPER nitpick, but other options don't have a space after the comma.
And noalign is exclusive to sunit/sw options (right?), so maybe the
output should look like:
/* data subvol */ [-d agcount=n,agsize=n,file,name=xxx,size=num,
(sunit=value,swidth=value|su=num,sw=num|noalign),
sectlog=n|sectsize=num
also: I think it's hilarious that we emit C comment strings in usage() ;)
-Eric
> /* force overwrite */ [-f]\n\
> /* inode size */ [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
> projid32bit=0|1]\n\
>
More information about the xfs
mailing list