[PATCH] xfs: fix bad dquot buffer size in log recovery readahead
Ben Myers
bpm at sgi.com
Tue Aug 27 16:45:34 CDT 2013
On Tue, Aug 27, 2013 at 01:25:43PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
>
> xfstests xfs/087 fails 100% reliably with this assert:
>
> XFS (vdb): Mounting Filesystem
> XFS (vdb): Starting recovery (logdev: internal)
> XFS: Assertion failed: bp->b_flags & XBF_STALE, file: fs/xfs/xfs_buf.c, line: 548
>
> while trying to read a dquot buffer in xlog_recover_dquot_ra_pass2().
>
> The issue is that the buffer length to read that is passed to
> xfs_buf_readahead is in units of filesystem blocks, not disk blocks.
> (i.e. FSB, not daddr). Fix it but putting the correct conversion in
> place.
>
> Signed-off-by: Dave Chinner <dchinner at redhat.com>
Looks good.
Reviewed-by: Ben Myers <bpm at sgi.com>
More information about the xfs
mailing list