[PATCH] xfstests: generic/255: Execute only if blocksize <= 4096

chandan chandan at linux.vnet.ibm.com
Mon Aug 26 00:38:24 CDT 2013


On Sunday, August 25, 2013 11:54:30 AM Eric Sandeen wrote:
> Can you explain why this is necessary?
> 
> What failures do you see, on what filesystems?

generic/255 currently fails on Btrfs on a ppc64 machine with 64k page size and
hence 64k block size.

generic/255 has been written to test the corner cases for 4k block size. I did
try to make it work with variable sized block sizes, But I got stuck
working with md5sum (since we would need two sets of md5sums, due to
_test_generic_punch() being invoked with and without '-k' option per block
size). 

Since 4k block size support for Btrfs on ppc64 is already being worked on, I
think its better to prevent execution of generic/255 for block sizes greater
than 4k.

Apologies for not including the above description in the patch.

- chandan



More information about the xfs mailing list