[PATCH] xfs: avoid double-free in xfs_attr_node_addname
Ben Myers
bpm at sgi.com
Tue Aug 13 16:34:12 CDT 2013
On Wed, Jul 31, 2013 at 08:18:54PM -0500, Eric Sandeen wrote:
> xfs_attr_node_addname()'s error handling tests whether it
> should free "state" in the out: error handling label:
>
> out:
> if (state)
> xfs_da_state_free(state);
>
> but an earlier free doesn't set state to NULL afterwards; this
> could lead to a double free. Fix it by setting state to NULL
> after it's freed.
>
> This was found by Coverity.
>
> Signed-off-by: Eric Sandeen <sandeen at redhat.com>
Applied.
More information about the xfs
mailing list