[PATCH] xfs: call roundup_64() to calculate the min_logblks
Dave Chinner
david at fromorbit.com
Tue Aug 13 01:53:55 CDT 2013
On Tue, Aug 13, 2013 at 01:32:00PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu at oracle.com>
>
> Replace roundup() with roundup_64() as we calculate min_logblks
> with 64-bit divisions. Hence, call roundup() will cause the
> following error while compiling a 32-bit kernel:
>
> fs/built-in.o: In function `xfs_log_calc_minimum_size':
> fs/xfs/xfs_log_rlimit.c:140: undefined reference to `__udivdi3'
>
> Reported-by: Fengguang Wu <fengguang.wu at intel.com>
> Cc: Dave Chinner <dchinner at redhat.com>
> Signed-off-by: Jie Liu <jeff.liu at oracle.com>
You beat me to it, Jeff. I got an email from Fengguang's build farm,
too. :)
Your fix looks good.
Reviewed-by: Dave Chinner <dchinner at redhat.com>
--
Dave Chinner
david at fromorbit.com
More information about the xfs
mailing list