[v2 PATCH 8/14] xfsprogs: fix issues with e0607266f23

Ben Myers bpm at sgi.com
Fri Aug 9 09:00:57 CDT 2013


On Thu, Aug 08, 2013 at 06:34:28PM -0500, Eric Sandeen wrote:
> On 8/8/13 6:26 PM, Eric Sandeen wrote:
> > On 8/8/13 5:28 PM, Ben Myers wrote:
> >> * remove unused uuid unparse in xfs_agf_verify
> >> * fix an unnecessary loop in clear_dinode_core
> > 
> > These should be 2 commits (they do 2 different things),
> > with properly descriptive summaries & changelogs.
> > 
> > For the 2nd, it's not an unnecessary loop, it's a memory
> > corruptor; that should be noted in the changelog.
> > 
> > TBH I've only reviewed the latter, I need to look at
> > the first.
> 
> Yup the first is fine too, but should be a separate commit.

Sounds good, thanks Eric.



More information about the xfs mailing list