[PATCH 1/14] libxfs: don't verify bmbt reads twice

Ben Myers bpm at sgi.com
Thu Aug 8 16:07:32 CDT 2013


xfs_bmbt_read_verify is calling xfs_bmbt_verify twice in a row.  commit
ee1a47ab0e in the kernel removed the first xfs_bmbt_verify but this was
not carried over when it was implemented in userspace.

Signed-off-by: Ben Myers <bpm at sgi.com>

---
 libxfs/xfs_bmap_btree.c |    2 --
 1 file changed, 2 deletions(-)

Index: b/libxfs/xfs_bmap_btree.c
===================================================================
--- a/libxfs/xfs_bmap_btree.c	2013-08-08 15:56:12.960817743 -0500
+++ b/libxfs/xfs_bmap_btree.c	2013-08-08 15:56:14.150857067 -0500
@@ -759,7 +759,6 @@ static void
 xfs_bmbt_read_verify(
 	struct xfs_buf	*bp)
 {
-	xfs_bmbt_verify(bp);
 	if (!(xfs_btree_lblock_verify_crc(bp) &&
 	      xfs_bmbt_verify(bp))) {
 		trace_xfs_btree_corrupt(bp, _RET_IP_);
@@ -767,7 +766,6 @@ xfs_bmbt_read_verify(
 				     bp->b_target->bt_mount, bp->b_addr);
 		xfs_buf_ioerror(bp, EFSCORRUPTED);
 	}
-
 }
 
 static void



More information about the xfs mailing list