[PATCH] xfs: xfs: fallback to vmalloc for large buffers in xfs_compat_attrlist_by_handle

Mark Tinguely tinguely at sgi.com
Thu Apr 25 11:43:37 CDT 2013


On 04/25/13 11:13, Eric Sandeen wrote:
> Shamelessly copied from dchinner's:
> ad650f5b xfs: fallback to vmalloc for large buffers in xfs_attrmulti_attr_get
>
> xfsdump uses a large buffer for extended attributes, which has a
> kmalloc'd shadow buffer in the kernel. This can fail after the
> system has been running for some time as it is a high order
> allocation. Add a fallback to vmalloc so that it doesn't require
> contiguous memory and so won't randomly fail while xfsdump is
> running.
>
> This was done for xfs_attrlist_by_handle but
> xfs_compat_attrlist_by_handle (the 32-bit version) needs the same
> attention.
>
> Signed-off-by: Eric Sandeen<sandeen at redhat.com>
> ---

Looks shamelessly good.

Reviewed-by: Mark Tinguely <tinguely at sgi.com>



More information about the xfs mailing list