[PATCH 2/5] xfstests: Use libtool to install applications

[Boris Ranto]

Greg,

sure, currently, I use the following spec file to package it (I've trimmed
things like changelog to limit the space used):
--------------------------------------------------- SPEC FILE
-----------------------------------------------------------------------
Name:          xfstests
Version:        20130415
Release:       3.git
Summary:     xfs qa tests

Group:             misc
License:           GPL
URL:
http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/cmds/xfstests.git
Source0:          $RPM_BUILD_ROOT/SOURCES/xfstests-dev.tar.bz2
BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

BuildRequires:  autoconf, libtool, e2fsprogs-devel, xfsprogs-devel
BuildRequires:  libacl-devel, libattr-devel, libaio-devel
Requires:         bash, perl, acl, attr, bind-utils
Requires:         bc, indent, quota, xfsprogs

%description
The xfsqa test available at git://oss.sgi.com/xfs/cmds/xfstests.git.

%prep
%setup -q -n xfstests-dev

%build
autoheader
autoconf
%configure
make %{?_smp_mflags}

%install
rm -rf $RPM_BUILD_ROOT
# Dirty workaround, xfstests won't build if these two directories do not
exist...
mkdir -p /var/lib/xfstests/{ltp,src}

make DIST_ROOT=$RPM_BUILD_ROOT install

%clean
rm -rf $RPM_BUILD_ROOT


%files
%defattr(-,root,root,-)
%doc README
/var/lib/xfstests
--------------------------------------------------- SPEC FILE
-----------------------------------------------------------------------

Before the libtool was used for installation I didn't need the workaround
(mkdir -p /var/lib/xfstets/{src,ltp}). Additionally, there is a template
spec file in xfstests git repository (build/rpm/xfstests.spec.in) that you
can use.

I get the tar.bz2 package from git repository by:
git archive --format=tar --output xfstests-dev.tar --prefix=xfstests-dev/
bzip2 xfstests-dev.tar

btw: I did not originally write the file, I just maintain it, now. I
suppose that Eric Sandeen is the one who originally wrote the .spec file.

Regards,
Boris



On Thu, Apr 18, 2013 at 2:46 PM, Greg Freemyer <greg.freemyer at gmail.com>wrote:

>
>
> Boris Ranto <ranto.boris at gmail.com> wrote:
>
> >Rich,
> >
> >just as Eric guessed, I package the xfstests test suite (and that is
> >also
> >why I need the DIST_ROOT variable functioning properly). Although I can
> >currently work around the problem  by doing something like
> >
> >./configure
> >make
> >mkdir -p /var/lib/xfstets/{ltp,src}
> >make DIST_ROOT=$RPM_BUILD_ROOT install
> >
> >it certainly is not the best solution to the problem. If the test suite
> >is
> >completely independent from its location then also maybe this could
> >work (I
> >did not try it, yet and I'm still not sure it is the best solution)
> >
> >./configure --prefix=$RPM_BUILD_ROOT
> >make
> >make install
> >
> >but if that is the case then it'd probably make sense to drop the whole
> >DIST_ROOT support from install-sh script to avoid confusion and update
> >the
> >spec file in bulld/rpm/.
> >
> >Regards,
> >Boris
>
> Boris,
>
> When you get it working for packaging purposes I'd appreciate a post
> detailing what works.  I thought about packaging xfstests for opensuse a
> couple years ago but aborted the effort when I realized it was not designed
> to be installed at the time.
>
> Greg
> --
> Sent from my Android phone with K-9 Mail. Please excuse my brevity.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20130418/0c40541c/attachment.html>