Bug#695640: xfs_quota: cannot find mount point for path: Success

[Brian May]

Oops. Just realized I still hadn't responded. Sorry.


On 20 March 2013 22:09, Dave Chinner <david at fromorbit.com> wrote:

> > > # xfs_quota  -x -c "quota -N -u brian"
> >
> > This prints the quota information 20 times. Huh?
>
> How many mount points do you have? 20?
>

No. More actually. Today I get

hq ~ # cat /proc/mounts  | wc --lines
34
hq ~ # xfs_quota  -x -c "quota -N -u brian" | wc --lines
44
hq ~ # xfs_quota  -x -c "quota -N -u brian" /home /share | wc --lines
4


> The command has once for each of the mount points, and the command
> itself iterates mount points because you haven't given it a mount
> point to look at. So, double iteration.  This same problem was fixed
> for the report command by setting it to be a global command i.e. the
> fix I mentioned previously that you tested should prevent this
> second case, and maybe even the first.
>

As far as I can tell this happens with the patched xfs_quota.

hq /home/brian/xfsprogs # git diff
diff --git a/quota/quot.c b/quota/quot.c
index a7782b4..6cb665d 100644
--- a/quota/quot.c
+++ b/quota/quot.c
@@ -418,6 +418,7 @@ quot_init(void)
        quot_cmd.args = _("[-bir] [-gpu] [-acv] [-f file]");
        quot_cmd.oneline = _("summarize filesystem ownership");
        quot_cmd.help = quot_help;
+       quot_cmd.flags = CMD_FLAG_GLOBAL;

        if (expert)
                add_command(&quot_cmd);

As this version is based on git, I just did a git pull:

hq /home/brian/xfsprogs # git pull
Updating b326e06..64ae7fc
Fast-forward
 mkfs/xfs_mkfs.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)

Doesn't look related to this, don't think I need to retest.
-- 
Brian May <brian at microcomaustralia.com.au>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20130418/5ce1e787/attachment.html>