xfstests: kludge patch for per-dir test number sorting by ./check

Michael L. Semon mlsemon35 at gmail.com
Sat Apr 13 15:50:06 CDT 2013


I'm trying to get the new xfstests to run the XFS tests first, then run 
the generic group, then run the shared group.  One attempt was to work 
with this variable in the ./check script:

SRC_GROUPS="generic shared"

There is a final file sort in ./check that means, no matter which order 
groups are specified in SRC_GROUPS, the groups will be executed in 
alphabetical order.  This sysadmin kludge patch fixes that behavior and 
seems to work.  By moving the sorting into the trim_test_list() 
function, test numbers are still sorted, but the groups seem to run in 
the order specified in the SRC_GROUPS variable.

Let me know if this helps or if I'm simply not using the new xfstests 
correctly.

Michael

--- xfstests/check.orig	2013-03-30 00:54:37.000000000 -0400
+++ xfstests/check	2013-04-13 13:41:42.002814733 -0400
@@ -138,7 +138,7 @@
  	    echo "^$t\$" >>$tmp.grep
  	    numsed=`expr $numsed + 1`
  	done
-	grep -v -f $tmp.grep <$tmp.list >$tmp.tmp
+	grep -v -f $tmp.grep <$tmp.list | sort -n >$tmp.tmp
  	mv $tmp.tmp $tmp.list
  }

@@ -268,7 +268,7 @@
  fi

  # sort the list of tests into numeric order
-list=`sort -n $tmp.list`
+list=`cat $tmp.list`
  rm -f $tmp.list $tmp.tmp $tmp.grep

  if $randomize



More information about the xfs mailing list