[PATCH v2] xfstests: make install support common/ and tests/ dirs

[Dave Chinner]

On Sat, Apr 13, 2013 at 12:42:20AM +0800, Wang Sheng-Hui wrote:
> On 2013年04月12日 15:40, Dave Chinner wrote:
> >On Fri, Apr 12, 2013 at 12:26:53PM +0800, Wang Sheng-Hui wrote:
> >>+#
> >>+
> >>+TOPDIR = ..
> >>+include $(TOPDIR)/include/builddefs
> >>+
> >>+TESTS_SUBDIRS = $(shell find . -maxdepth 1 -type d | sed -n -e 's/\.\///gp')
> >
> >This is much neater:
> >
> >TESTS_SUBDIRS = $(sort $(dir $(wildcard  $(PWD)/*/)))
> 
> Hi Dave,
> 
> I introduces Makefile under tests/, which would return to TESTS_SUBDIRS with the
> $(dir function. By running find in $(shell, TEST_SUBDIRS will only get the dir names,
> and no Makefile.

I think you misunderstand. The wildcard above only returns
directories:

$ pwd
 0  ~/src/xfstests-dev/tests
$ cat ~/tmp/Makefile 
foo=$(sort $(dir $(wildcard  $(PWD)/*/)))

default:
        @echo $(foo)
$ make -f ~/tmp/Makefile 
/home/dave/src/xfstests-dev/tests/btrfs/ /home/dave/src/xfstests-dev/tests/ext4/ /home/dave/src/xfstests-dev/tests/generic/ /home/dave/src/xfstests-dev/tests/shared/ /home/dave/src/xfstests-dev/tests/udf/ /home/dave/src/xfstests-dev/tests/xfs/
$

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com