[patch 0/2] dmapi: build system revamp

Ben Myers bpm at sgi.com
Wed Oct 31 08:59:02 CDT 2012


Hey Christoph,

On Wed, Oct 31, 2012 at 06:21:53AM -0400, Christoph Hellwig wrote:
> On Tue, Oct 30, 2012 at 04:01:52PM -0500, Ben Myers wrote:
> > Hi,
> > 
> > Here are Jan Engelhardt's patches originally posted here
> > http://oss.sgi.com/archives/xfs/2012-05/msg00323.html
> > as they apply to dmapi.  
> > 
> > Patch 2 applied without much modification, patch 3 was not necessary for dmapi,
> > and patch 6 did not apply at all so I implemented that.
> 
> All the patches in this and the related series look good to me.
> but can you please remove the [PATCH N/N] already in the quilt series?
> 
> Right now we have one [patch n/n] generated by quilt and then another
> mismatching one, which I think would even land in the git commit log.

Aha.  I will clean up the extra [patch n/n].  I didn't expect it would do that.

> Reviewed-by: Christoph Hellwig <hch at lst.de>

Thanks for the review!

-Ben



More information about the xfs mailing list