[PATCH 01/25] xfs: growfs: don't read garbage for new secondary superblocks

Phil White pwhite at sgi.com
Mon Oct 29 19:17:50 CDT 2012


On Thu, Oct 25, 2012 at 05:33:50PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> When updating new secondary superblocks in a growfs operation, the
> sueprblock buffer is read from the newly grown region of the
> underlying device. This is not guaranteed to be zero, so violates
> the underlying assumption that the unused parts of superblocks are
> zero filled. Get a new buffer for these secondary superblocks to
> ensure that the unused regions are zero filled correctly.
> 
> Signed-off-by: Dave Chinner <dchinner at redhat.com>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> ---
> [ snip ]

Looks good to me too. 

Reviewed-by: Phil White <pwhite at sgi.com>



More information about the xfs mailing list