[PATCH v3] xfstests: Use upstream version of fstrim instead of the local one

Rich Johnston rjohnston at sgi.com
Wed Oct 24 15:51:53 CDT 2012


Thomas,

On 10/04/2012 03:13 PM, Tomas Racek wrote:
> ----- Original Message -----
>> On Thu, 4 Oct 2012, Tomas Racek wrote:
>>

>> Ok, so the reason is to strip the variable mount point from the
>> error message. It sounds ok than.
>>
>> This makes me think that we maybe want to have a filter function to
>> filter out all the variables such as SCRATCH_MNT, SCRATCH_DEV,
>> TEST_DIR,
>> TEST_DEV and maybe more and replace then with the some appropriate
>> strings
>> (SCRATCH_MNT etc. maybe?). I am sure more tests can benefit from this
>> not
>> needing to to the filtering on their own.
>
> Oh, thanks for reminding me -- they already exist (see common.filter), I forgot about them. I will use them in next version. ;-)
>
>
> Tom
>


V4 has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch.

Regards
--Rich



More information about the xfs mailing list