[PATCH 1/2] 286: Test FITRIM where length is smaller than FSB

[Rich Johnston]

On 10/24/2012 03:39 PM, Rich Johnston wrote:
> Lukas,
>
> On 10/16/2012 03:16 PM, Dave Chinner wrote:
>> On Tue, Oct 16, 2012 at 11:41:33AM +0200, Lukas Czerner wrote:
>>> This tests corner case in FITRIM implementation where range size is
>>> smaller than file system block or zero. In this case FITRIM should fail
>>> with EINVAL.
>>>
>>> The problem was spotted in xfs and ext4 where in case of length = 0 the
>>> 'end' variable underflowed. In case of length smaller than 1 FSB FITRIM
>>> finished successfully, but we really should rather return EINVAL in both
>>> cases.
>>>
>>> (This patch has to be applied after 'Use upstream version of fstrim
>>> instead of the local one')
>>>
>>> Signed-off-by: Lukas Czerner <lczerner at redhat.com>
>>> ---
>>>   286     |   58
>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>   286.out |    6 ++++++
>>
>> We've already got 286 (and 287), so this should probably be 288...
>>
>> Otherwise, it looks good.
>>
>> Reviewed-by: Dave Chinner <dchinner at redhat.com>
>>
>
> This has been committed to git://oss.sgi.com/xfs/xfs.git, master and
> for-next branches.
>
> Regards
> --Rich
>
> _______________________________________________
> xfs mailing list
> xfs at oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

My apologies, this has been committed to 
git://oss.sgi.com/xfs/cmds/xfstests, master and for-next branches.

Regards
--Rich