[PATCH 2/2] 251: Do not allow step to be zero

Rich Johnston rjohnston at sgi.com
Wed Oct 24 15:43:04 CDT 2012


Lukas,

On 10/16/2012 03:18 PM, Dave Chinner wrote:
> On Tue, Oct 16, 2012 at 11:41:34AM +0200, Lukas Czerner wrote:
>> Currently 'step' variable which is used as length of the range to
>> discard can be zero. However it would result in error returned by the
>> fstrim.
>>
>> Fix this by forcing 'step' to be at least 4KB.
>>
>> Signed-off-by: Lukas Czerner <lczerner at redhat.com>
>
> Looks fine. It may not be perfect for large block filesystems (e.g.
> on ppc or ia64) but it's better than nothing right now.
>
> Reviewed-by: Dave Chinner <dchinner at redhat.com>
>

This has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master 
and for-next branches.

Regards
--Rich



More information about the xfs mailing list