[PATCH v2] xfstests: get return value in seek_sanity_test

wenqing.lz gnehzuil.liu at gmail.com
Sun Oct 21 08:15:09 CDT 2012


From: Zheng Liu <wenqing.lz at taobao.com>

In seek_sanity_test getting return value is missing.  Thus we couldn't get the
result unless someone read the log file (e.g. # 285).

CC: Jeff Liu <jeff.liu at oracle.com>
Signed-off-by: Zheng Liu <wenqing.lz at taobao.com>
---
v2 <- v1:
	* put return value check below the run_test()

Hi Jeff,

Could you please review this patch again?  Thanks.

Regards,
Zheng

 src/seek_sanity_test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
index 34f5508..3897f02 100644
--- a/src/seek_sanity_test.c
+++ b/src/seek_sanity_test.c
@@ -674,9 +674,9 @@ int main(int argc, char **argv)
 		goto out;
 
 	for (i = 0; i < numtests; ++i) {
+		ret = run_test(&seek_tests[i]);
 		if (ret)
-			goto out;
-		run_test(&seek_tests[i]);
+			break;
 	}
 
 out:
-- 
1.7.12.rc2.18.g61b472e



More information about the xfs mailing list