[PATCH 2/2] 251: Do not allow step to be zero

Dave Chinner david at fromorbit.com
Tue Oct 16 15:18:29 CDT 2012


On Tue, Oct 16, 2012 at 11:41:34AM +0200, Lukas Czerner wrote:
> Currently 'step' variable which is used as length of the range to
> discard can be zero. However it would result in error returned by the
> fstrim.
> 
> Fix this by forcing 'step' to be at least 4KB.
> 
> Signed-off-by: Lukas Czerner <lczerner at redhat.com>

Looks fine. It may not be perfect for large block filesystems (e.g.
on ppc or ia64) but it's better than nothing right now.

Reviewed-by: Dave Chinner <dchinner at redhat.com>

-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list