[PATCH v2] xfs: avoid underflow in xfs_ioc_trim()

Dave Chinner david at fromorbit.com
Thu Oct 11 16:35:33 CDT 2012


On Thu, Oct 11, 2012 at 10:33:52AM +0200, Lukas Czerner wrote:
> Currently if len argument in xfs_ioc_trim() is smaller than one FSB
> the 'end' variable underflow. Avoid that by returning EINVAL when
> range is smaller than FSB.
> 
> Signed-off-by: Lukas Czerner <lczerner at redhat.com>

Just a thought - wouldn't this be better done at the VFS so it is
consistent across all filesystems? i.e. using inode->i_blkbits?

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list