[PATCH 2/2] xfsprogs: report projid32 status in growfs output

Dave Chinner david at fromorbit.com
Tue Oct 9 14:47:52 CDT 2012


On Tue, Oct 09, 2012 at 02:21:14PM -0500, Eric Sandeen wrote:
> With the projid32 flag now in the FSGEOM ioctl results we
> can report projid32 status in xfs_growfs / xfs_info output,
> to match the mkfs.xfs output.
> 
> However, since the flag was only recently added to the kernel,
> we may get some incorrect reports of "projid32bit=0"
> 
> Signed-off-by: Eric Sandeen <sandeen at redhat.com>
> ---
> 
> ... and I don't know how big a problem those incorrect reports
> might be ...

I doubt it will be a problem - the 32bit projid is pretty
self-contained, and we can still get the info from xfs_db if we
really need to confirm that it is set.

Code looks good.

Reviewed-by: Dave Chinner <dchinner at redhat.com>

-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list