[PATCH 06/13] xfs: xfs_sync_data is redundant.

Ben Myers bpm at sgi.com
Mon Oct 1 12:44:10 CDT 2012


Hi Dave,

On Fri, Sep 28, 2012 at 08:34:43AM -0400, Christoph Hellwig wrote:
> >  /*
> > + * Flush all dirty data to disk. Must not be called while holding an XFS_ILOCK
> 
> slightly too long line.

It comes out at 78 columns when the patch is applied.  Not a problem.

> > + * or a page lock.
> > + */
> > +static inline void
> > +xfs_flush_inodes(struct xfs_inode *ip)
> > +{
> > +	writeback_inodes_sb_if_idle(VFS_I(ip)->i_sb, WB_REASON_FS_FREE_SPACE);
> > +}
> 
> Passing an inode here seems very odd, an xfs_mount would be the proper
> interface. 
> 
> Looks fine modulo these cosmetic changes, so:
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>

I cleaned up these cosmetic changes on your behalf.  Here is the result:




More information about the xfs mailing list