[PATCH 08/32] xfs: make growfs initialise the AGFL header

Christoph Hellwig hch at infradead.org
Fri Nov 23 06:41:19 CST 2012


On Mon, Nov 12, 2012 at 10:54:00PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> For verification purposes, AGFLs need to be initialised to a known
> set of values. For upcoming CRC changes, they are also headers that
> need to be initialised. Currently, growfs does neither for the AGFLs
> - it ignores them completely. Add initialisation of the AGFL to be
> full of invalid block numbers (NULLAGBLOCK) to put the
> infrastructure in place needed for CRC support.
> 
> Includes a comment clarification from Jeff Liu.

Looks good.

If you plan to touch this code even more I'd suggst splitting out a
helper for each kinda of block / header that is initialized from
xfs_growfs_data_private.

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list