[PATCH 17/32 V2] xfs: verify dquot blocks as they are read from disk

[Mark Tinguely]

On 11/15/12 15:16, Dave Chinner wrote:
> On Thu, Nov 15, 2012 at 03:01:49PM -0600, Mark Tinguely wrote:
>> On 11/15/12 14:48, Dave Chinner wrote:
>>> On Thu, Nov 15, 2012 at 11:55:47AM -0600, Mark Tinguely wrote:
>>>> The xfs_quota program does not generate output with V2 which causes
>>>> xfstest 050 to fails.
>>>
>>> I don't think that has anything to do with this patch orthechange
>>> for V2 - V2 only changes quotacheck behaviour, and that doesn't
>>> impact xfs_quota behaviour. The test passes just fine here:
>>>
>>> $ sudo ./check 050
>>> FSTYP         -- xfs (debug)
>>> PLATFORM      -- Linux/x86_64 test-2 3.7.0-rc5-dgc+
>>> MKFS_OPTIONS  -- -f -bsize=4096 /dev/vdb
>>> MOUNT_OPTIONS -- /dev/vdb /mnt/scratch
>>>
>>> 050 14s ... 15s
>>> Ran: 050
>>> Passed all 1 tests
>>>
>>> So perhaps there's something else going wrong on your machine?
>>
>> I will do more investigating. With V2 050 output:
>>
>> QA output created by 050
>> *** user
>> meta-data=DDEV isize=XXX agcount=N, agsize=XXX blks
>> data     = bsize=XXX blocks=XXX, imaxpct=PCT
>>           = sunit=XXX swidth=XXX, unwritten=X
>> naming   =VERN bsize=XXX
>> log      =LDEV bsize=XXX blocks=XXX
>> realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX
>>
>> *** report no quota settings
>>
>> *** report initial settings
>>
>> *** push past the soft inode limit
>>
>> *** push past the soft block limit
>
> Curious. There aren't any errors in the syslog/dmesg saying that
> buffers failed verification during the quota check runs, are there?
> Also, what platform are you testing on?
>
> Cheers,
>
> Dave.

No error message in dmesg nor /var/log/messages

This is a x86_64.

It is running OSS with most recent commit:

  commit 579b62faa5fb16ffeeb88cda5e2c4e95730881af

Your two series:
	xfs: fixes for 3.7-rc6
	xfs: current queue for 3.8

I added the XFS_SB_VERSION2_CRCBIT attribute to xfsprogs and enabled it 
in mkfs.xfs and remade the test/scratch filesystems.

I will refresh the kernel when the rest of the 3.8 queue series is 
updated in OSS.

--Mark.