[PATCH 19/32] xfs: factor dir2 block read operations

Ben Myers bpm at sgi.com
Wed Nov 14 21:09:28 CST 2012


On Mon, Nov 12, 2012 at 10:54:11PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> In preparation for verifying dir2 block format buffers, factor
> the read operations out of the block operations (lookup, addname,
> getdents) and some of the additional logic to make it easier to
> understand an dmodify the code.
> 
> Signed-off-by: Dave Chinner <dchinner at redhat.com>

This was a difficult review.  I think you have at least three ideas in here
which could be split up.  Please keep the reviewer in mind.

Reviewed-by: Ben Myers <bpm at sgi.com>



More information about the xfs mailing list