[PATCH 5/6] xfs: fix buffer shudown reference count mismatch

Mark Tinguely tinguely at sgi.com
Fri Nov 2 12:10:02 CDT 2012


On 11/02/12 08:13, Christoph Hellwig wrote:
> I don't like this.  ioend processing is very different for synchrous
> writes, with the most important difference being that synchronous
> writes need to wake the submitter at I/O completion.  From all I can
> see your v2 patch breaks that beahviour.  For 3.7-rc I'd suggest
> taking the additional reference conditionally.
>
> For 3.8 I'm going to look into simply acquiring an additional reference
> for synchronous writes during I/O submission to kill these special cases
> all over the buffer code.

Testing shows that conditionally taking the additional reference does
work at avoiding the b_bhold is zero assert without causing pag is not
empty assert.

Thanks,

--Mark Tinguely.



More information about the xfs mailing list