[XFS updates] XFS development tree branch, master, updated. v3.4-rc2-57-g14c26c6
xfs at oss.sgi.com
xfs at oss.sgi.com
Mon May 21 13:26:42 CDT 2012
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".
The branch, master has been updated
14c26c6 xfs: add trace points for log forces
3ba3160 xfs: fix memory reclaim deadlock on agi buffer
ea562ed xfs: fix delalloc quota accounting on failure
from 1307bbd2af67283131728637e9489002adb26f10 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 14c26c6a05de138a4fd9a0c05ff8e7435a618324
Author: Dave Chinner <dchinner at redhat.com>
Date: Tue Apr 24 16:33:31 2012 +1000
xfs: add trace points for log forces
To enable easy tracing of the location of log forces and the
frequency of them via perf, add a pair of trace points to the log
force functions. This will help debug where excessive log forces
are being issued from by simple perf commands like:
# ~/perf/perf top -e xfs:xfs_log_force -G -U
Which gives this sort of output:
Events: 141 xfs:xfs_log_force
- 100.00% [kernel] [k] xfs_log_force
- xfs_log_force
87.04% xfsaild
kthread
kernel_thread_helper
- 12.87% xfs_buf_lock
_xfs_buf_find
xfs_buf_get
xfs_trans_get_buf
xfs_da_do_buf
xfs_da_get_buf
xfs_dir2_data_init
xfs_dir2_leaf_addname
xfs_dir_createname
xfs_create
xfs_vn_mknod
xfs_vn_create
vfs_create
do_last.isra.41
path_openat
do_filp_open
do_sys_open
sys_open
system_call_fastpath
Signed-off-by: Dave Chinner <dchinner at redhat.com>
Reviewed-by: Mark Tinguely <tinguely at sgi.com>
Signed-off-by: Ben Myers <bpm at sig.com>
commit 3ba316037470bbf98c8a16c2179c02794fb8862e
Author: Peter Watkins <treestem at gmail.com>
Date: Mon May 7 16:11:37 2012 -0400
xfs: fix memory reclaim deadlock on agi buffer
Note xfs_iget can be called while holding a locked agi buffer. If
it goes into memory reclaim then inode teardown may try to lock the
same buffer. Prevent the deadlock by calling radix_tree_preload
with GFP_NOFS.
Signed-off-by: Peter Watkins <treestem at gmail.com>
Reviewed-by: Dave Chinner <dchinner at redhat.com>
Signed-off-by: Ben Myers <bpm at sgi.com>
commit ea562ed6e7df5acd9392d993882c39e855099165
Author: Dave Chinner <dchinner at redhat.com>
Date: Tue May 8 20:48:53 2012 +1000
xfs: fix delalloc quota accounting on failure
xfstest 270 was causing quota reservations way beyond what was sane
(ten to hundreds of TB) for a 4GB filesystem. There's a sign problem
in the error handling path of xfs_bmapi_reserve_delalloc() because
xfs_trans_unreserve_quota_nblks() simple negates the value passed -
which doesn't work for an unsigned variable. This causes
reservations of close to 2^32 block instead of removing a
reservation of a handful of blocks.
Fix the same problem in the other xfs_trans_unreserve_quota_nblks()
callers where unsigned integer variables are used, too.
Signed-off-by: Dave Chinner <dchinner at redhat.com>
Reviewed-by: Eric Sandeen <sandeen at redhat.com>
Signed-off-by: Ben Myers <bpm at sgi.com>
-----------------------------------------------------------------------
Summary of changes:
fs/xfs/xfs_bmap.c | 2 +-
fs/xfs/xfs_iget.c | 5 +++--
fs/xfs/xfs_iomap.c | 2 +-
fs/xfs/xfs_log.c | 2 ++
fs/xfs/xfs_trace.h | 16 ++++++++++++++++
fs/xfs/xfs_vnodeops.c | 2 +-
6 files changed, 24 insertions(+), 5 deletions(-)
hooks/post-receive
--
XFS development tree
More information about the xfs
mailing list