[RFC PATCH 2/3] xfs: fix xfsaild hang due to premature idle
Ben Myers
bpm at sgi.com
Mon May 21 13:12:32 CDT 2012
Hey Brian,
On Mon, May 21, 2012 at 01:21:25PM -0400, Brian Foster wrote:
> Running xfstests 273 in a loop reproduces an XFS lockup due to
> xfsaild entering idle mode indefinitely. The following
> high-level sequence of events leads to the hang:
>
> - xfsaild is running, hits the stuck item threshold and reschedules,
> setting xa_last_pushed_lsn appropriately.
> - xa_threshold is updated.
> - xfsaild restarts from the previous xa_last_pushed_lsn, hits the
> new target and enters idle mode, even though the previously
> stuck items still populate the ail.
>
> Modify the tout logic to only enter idle mode when the ail is empty.
> IOW, if we hit the target but did not perform the current scan from
> the start of the ail, reschedule at least one more time.
>
> Signed-off-by: Brian Foster <bfoster at redhat.com>
Thanks for the patch. Unfortunately it does not apply cleanly. Care to spin it again?
Regards,
Ben
More information about the xfs
mailing list