[PATCH 2/5] xfs: reduce ilock hold times in xfs_file_aio_write_checks
Dave Chinner
david at fromorbit.com
Mon Mar 26 17:15:59 CDT 2012
On Mon, Mar 26, 2012 at 05:14:23PM -0400, Christoph Hellwig wrote:
> We do not need the ilock for generic_write_checks and the i_size read,
> which are protected by i_mutex and/or iolock, so reduce the ilock
> critical section to just the call to xfs_zero_eof.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
That answers one of the open questions I had about my patch -
whether we needed to hold the ilock at all over
generic_write_checks(). I wasn't 100% sure, but this patch confirms
my thinking on it.
Reviewed-by: Dave Chinner <dchinner at redhat.com>
--
Dave Chinner
david at fromorbit.com
More information about the xfs
mailing list