[PATCH] xfstests 235: do smaller test IO
Dave Chinner
david at fromorbit.com
Mon Mar 26 17:09:26 CDT 2012
On Mon, Mar 26, 2012 at 02:30:33PM -0500, Eric Sandeen wrote:
> Test 235 fails on ext2/ext3 with 1024 fs block size because a
> 16k write uses an extra metadata block. If we do a smaller write
> this won't happen.
.....
>
> -$XFS_IO_PROG -F -c 'pwrite 0 16k' -c 'fsync' \
> +$XFS_IO_PROG -F -c 'pwrite 0 8k' -c 'fsync' \
So now it fails only on 512 byte block size filesystems?
Perhaps rather than an exact match, a "within_tolerance" match could
be done on the relevant fields?
i.e something like:
blksused=`{requota cmd} | awk '/fsgqa/ { print $3 }'`
_within_tolerance "blocks used" $blksused 16 1
If you wanted to get really fancy, the tolerance could be set
depending on filesystem type and block size, but I don't think that
is really necessary....
Cheers,
Dave.
--
Dave Chinner
david at fromorbit.com
More information about the xfs
mailing list