[PATCH 9/9] xfs: factor buffer reading from xfs_dir2_leaf_getdents

Christoph Hellwig hch at infradead.org
Tue Jun 26 05:16:43 CDT 2012


On Fri, Jun 22, 2012 at 06:50:15PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> The buffer reading code in xfs_dir2_leaf_getdents is complex and difficult to
> follow due to the readahead and all the context is carries. it is also badly
> indented and so difficult to read. Factor it out into a separate function to
> make it easier to understand and optimise in future patches.
> 
> Signed-off-by: Dave Chinner <dchinner at redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list