[PATCH 5/7] xfs: refactor xfs_ialloc_ag_select

Dave Chinner david at fromorbit.com
Sun Jun 17 21:23:11 CDT 2012


On Tue, Jun 05, 2012 at 10:46:52AM -0400, Christoph Hellwig wrote:
> Loop over the in-core perag structures and prefer using pagi_freecount over
> going out to the AGI buffer where possible.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Looks good. One minor thing:

> @@ -901,13 +897,13 @@ xfs_dialloc(
>  	xfs_buf_t	**IO_agbp,	/* in/out ag header's buffer */
>  	xfs_ino_t	*inop)		/* inode number allocated */
>  {
> +	xfs_mount_t	*mp = tp->t_mountp;

struct xfs_mount

Otherwise,

Reviewed-by: Dave Chinner <dchinner at redhat.com>

-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list