[PATCH] xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent()
Eric Sandeen
sandeen at redhat.com
Fri Jun 8 14:32:42 CDT 2012
w/o this change I was getting:
[ 742.376495] ODEBUG: object is on stack, but not annotated
[ 742.377007] ------------[ cut here ]------------
[ 742.377007] WARNING: at lib/debugobjects.c:302 __debug_object_init+0x1c0/0x3d0()
...
[ 742.377007] Call Trace:
[ 742.377007] [<ffffffff81060dbf>] warn_slowpath_common+0x7f/0xc0
[ 742.377007] [<ffffffff81060e1a>] warn_slowpath_null+0x1a/0x20
[ 742.377007] [<ffffffff81336640>] __debug_object_init+0x1c0/0x3d0
[ 742.377007] [<ffffffff8133689f>] debug_object_init+0x1f/0x30
[ 742.377007] [<ffffffff81081cd9>] __init_work+0x19/0x30
[ 742.377007] [<ffffffffa0299f81>] xfs_alloc_vextent+0x101/0x190 [xfs]
on a debug 3.4 kernel.
Signed-off-by: Eric Sandeen <sandeen at redhat.com>
---
I think it's right? :)
diff --git a/fs/xfs/xfs_alloc.c b/fs/xfs/xfs_alloc.c
index 0f0df27..0be396d 100644
--- a/fs/xfs/xfs_alloc.c
+++ b/fs/xfs/xfs_alloc.c
@@ -2443,7 +2443,7 @@ xfs_alloc_vextent(
DECLARE_COMPLETION_ONSTACK(done);
args->done = &done;
- INIT_WORK(&args->work, xfs_alloc_vextent_worker);
+ INIT_WORK_ONSTACK(&args->work, xfs_alloc_vextent_worker);
queue_work(xfs_alloc_wq, &args->work);
wait_for_completion(&done);
return args->result;
More information about the xfs
mailing list