[PATCH] Printk for ENOSPC due to lack of inodes

[Raghavendra D Prabhu]

Hi,

Thanks for reviewing earlier.

I have sent the patch series here from: http://oss.sgi.com/archives/xfs/2012-06/msg00020.html to http://oss.sgi.com/archives/xfs/2012-06/msg00023.html


* On Thu, May 31, 2012 at 10:31:21PM -0500, Eric Sandeen <sandeen at sandeen.net> wrote:
>On 5/31/12 2:36 PM, Raghavendra D Prabhu wrote:
>> Hi,
>>
>> Thanks for the review. I have now moved it inside xfs_dialloc. Along with adding the message, I noticed that the loop
>>
>>     while (!agi->agi_freecount) {
>>     }
>>
>> is redundant when noroom=1 and okalloc=0.
>>
>> Also, xfs_ialloc_ag_alloc function in the loop calls
>> ============
>>     if (mp->m_maxicount &&
>>         mp->m_sb.sb_icount + XFS_IALLOC_INODES(mp) > mp->m_maxicount) {
>>
>> ===============
>>
>> condition again.
>>
>> So I have moved xfs_tran_brelse etc. into the condition along with message.
>>
>> Is this logic valid? If it is, then I will look into rate-limiting the message etc.
>
>It'd be easiest to understand this new change as a patch rather than as a description.
>
>If you are changing logic or flow in addition to adding the messages, it should almost certainly be sent as more than one patch.
>
>Thanks,
>
>-eric
>
>_______________________________________________
>xfs mailing list
>xfs at oss.sgi.com
>http://oss.sgi.com/mailman/listinfo/xfs
>




Regards,
-- 
Raghavendra Prabhu
GPG Id : 0xD72BE977
Fingerprint: B93F EBCB 8E05 7039 CD3C A4B8 A616 DCA1 D72B E977
www: wnohang.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20120605/54a64dd3/attachment.sig>