[PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks

Christoph Hellwig hch at infradead.org
Tue Jul 3 11:05:31 CDT 2012


On Tue, Jul 03, 2012 at 10:28:57AM +1000, Dave Chinner wrote:
> On Mon, Jul 02, 2012 at 06:00:05AM -0400, Christoph Hellwig wrote:
> > xfs_bdstrat_cb only adds a check for a shutdown filesystem over xfs_buf_iorequest,
> > but xfs_buf_iodone_callbacks just checked for a shut down filesystem a little
> > earlier.  In addition the shutdown handling in xfs_bdstrat_cb is not very suitable
> > for this caller.
> 
> Makes sense - I have a patch locally that does this as part of a
> xfs_buf_iorequest(bp, blkno, length) conversion to get rid of
> XFS_BUF_SETADDR()....

Can you send these out ASAP?  I have another big batch of buffer error
handling changes for 3.6 I'm working on right now.



More information about the xfs mailing list