[PATCH 2/2] xfs: do not call xfs_bdstrat_cb in xfs_buf_iodone_callbacks

Dave Chinner david at fromorbit.com
Mon Jul 2 19:28:57 CDT 2012


On Mon, Jul 02, 2012 at 06:00:05AM -0400, Christoph Hellwig wrote:
> xfs_bdstrat_cb only adds a check for a shutdown filesystem over xfs_buf_iorequest,
> but xfs_buf_iodone_callbacks just checked for a shut down filesystem a little
> earlier.  In addition the shutdown handling in xfs_bdstrat_cb is not very suitable
> for this caller.

Makes sense - I have a patch locally that does this as part of a
xfs_buf_iorequest(bp, blkno, length) conversion to get rid of
XFS_BUF_SETADDR()....

> Signed-off-by: Christoph Hellwig <hch at lst.de>

Reviewed-by: Dave Chinner <dchinner at redhat.com>

-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list